This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Separate round change reception from RoundChangeCertificate #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IBFT2.1 requires that message content be separated, thus concepts at the message level must not leak into the business logic - eg RoundChangeCertificate should not be created by the RoundChangeManager - rather an intermediate type is to be inserted.
CjHare
approved these changes
Feb 4, 2019
jframe
reviewed
Feb 4, 2019
| @@ -49,4 +52,33 @@ public Address getProposerOfBlock(final BlockHeader header) { | |||
| final IbftExtraData ibftExtraData = IbftExtraData.decode(header.getExtraData()); | |||
| return ibftExtraData.getValidators(); | |||
| } | |||
|
|
|||
| public int roundOfBlock(final BlockHeader header) { | |||
There was a problem hiding this comment.
Is this used, maybe it was added for later code?
| } | ||
|
|
||
| public static Block replaceRoundInBlock( | ||
| final Block block, final int round, final BlockHashFunction blockHashFunction) { |
There was a problem hiding this comment.
blockHashFunction isn't used
| .map(roundChange -> roundChange.getSignedPayload()) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| final Optional<PreparedCertificate> latestdPreparedCertificate = |
There was a problem hiding this comment.
nit: typo in latestdPreparedCertificate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBFT2.1 requires that message content be separated, thus concepts
at the message level must not leak into the business logic - eg
RoundChangeCertificate should not be created by the
RoundChangeManager - rather an intermediate type is to be inserted.