This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Introduce FutureUtils to reduce duplicated code around CompletableFuture #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Feb 15, 2019
| future.whenComplete( | ||
| (value, error) -> { | ||
| final CompletionStage<T> nextStep = | ||
| error != null ? errorHandler.apply(error) : completedFuture(value); |
There was a problem hiding this comment.
Should we add a try / catch around the errorHandler execution in case that function throws?
There was a problem hiding this comment.
Yep seems like a good idea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Introduce
FutureUtilsto provide some commonly required functionality aroundCompletableFuturesuch as creating a future that is completed exceptionally, handling exceptionally completed futures by composing with another future and propagating the result or exception from one future to another.Applies these utilities in a few places to simplify existing code. There will certainly be more places they could be used, but this is a start.