This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2305] Detect stalled world state downloads #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Feb 16, 2019
There was a problem hiding this comment.
LGTM. The simpler option I'd trialled was to simply count the number of requests since we last received a node. It wasn't bad but tuning the limit was challenging. I think this is probably a better approach since it's looking specifically for a node that's no longer available which is the more accurate signal.
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR updates
WorldStateDownloaderto track failure counts for each node requested from the network. If a node is retried more than a configurable number of times, the download fails.There is one potential issue with this approach. When a node request fails, it is added back to the queue and so moves to the "end of the line". So we could end up doing a lot of processing before we retry the node enough times to finally decide that the current world state isn't available. If this ends up being problematic, one fix might be to track failed nodes in a separate queue so we can process them more quickly.