This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2316] check permissions CLI dependencies #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
reviewed
Feb 19, 2019
| @@ -552,6 +552,13 @@ public void run() { | |||
| + "or specify the beneficiary of mining (via --miner-coinbase <Address>)"); | |||
| } | |||
|
|
|||
| if (permissionsConfigFile != null) { | |||
| if (!permissionsAccountsEnabled && !permissionsNodesEnabled) { | |||
| throw new ParameterException( | |||
There was a problem hiding this comment.
Do we want this to be an error? Convention here seems to be options that aren’t going to have an effect is a warning like on line 636.
There was a problem hiding this comment.
have posed the question for @jakehaugen
There was a problem hiding this comment.
changed to warning
…-permissions-cli-dependencies
…-permissions-cli-dependencies
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 20, 2019
* check nodes or accounts permissioning is enabled if config file is set
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
if permissions config file is set, check that either nodes or accounts whitelisting is enabled.
Fixed Issue(s)
fixes #PAN-2316