This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Incremental Optimization(s) on BlockBroadcaster #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Feb 19, 2019
| if (!totalDifficulty.isPresent()) { | ||
| final Optional<UInt256> maybeTotalDifficulty = | ||
| blockchain.getTotalDifficultyByHash(block.getHash()); | ||
| if (!maybeTotalDifficulty.isPresent()) { | ||
| throw new IllegalStateException( |
There was a problem hiding this comment.
I know this was pretty like this to start with but while you're here: blockchain.getTotalDifficultyByHash(block.getHash()).orElseThrow(() -> new IllegalStateException(...)) would be simpler.
There was a problem hiding this comment.
Yeah, for sure. I'll try to keep that pattern in mind in the future, it's not the first time you've given me this feedback
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 20, 2019
--> adapt `BlockBroadcaster` to use `send` method on `EthPeer` --> adapt `EthProtocolMamnager` to utilize `BlockBroadcaster` to disseminate newly mined block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
--> adapt
BlockBroadcasterto usesendmethod onEthPeer--> adapt
EthProtocolMamnagerto utilizeBlockBroadcasterto disseminate newly mined blockFixed Issue(s)