This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Improve RocksDBQueue dequeue performance #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives approximately a 10% perf improvement in isolation and in real-world tests allows the world state requests to actually reach the concurrent limit.
shemnon
approved these changes
Feb 19, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 20, 2019
Gives approximately a 10% perf improvement in isolation and in real-world tests allows the world state requests to actually reach the concurrent limit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The number of in-flight world state requests was consistently below the limit primarily because it took too long to dequeue pending requests from the RocksDB queue. This modifies RocksDbQueue to use an iterator for dequeuing instead of directly using
db.get.Also adds a benchmark so dequeue performance is tracked - shows about a 10% perf improvement over the previous implementation which appears to be enough to keep in-flight world state requests at the limit.