This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix for bug in the validation of Round-Change-Certificates #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saltiniroberto
force-pushed
the
fix_Round_Change_Message_Verification
branch
from
1ab32ff to
0eb7c19
Compare
saltiniroberto
changed the title
saltiniroberto
changed the title
saltiniroberto
force-pushed
the
fix_Round_Change_Message_Verification
branch
from
0eb7c19 to
6f9f74c
Compare
jframe
reviewed
Feb 26, 2019
| @@ -58,7 +59,8 @@ public boolean validateRoundChangeMessagesAndEnsureTargetRoundMatchesRoot( | |||
| final Collection<SignedData<RoundChangePayload>> roundChangeMsgs = | |||
| roundChangeCert.getRoundChangePayloads(); | |||
|
|
|||
| if (roundChangeMsgs.size() < quorum) { | |||
| if (roundChangeMsgs.stream().map(SignedData::getAuthor).collect(Collectors.toSet()).size() | |||
There was a problem hiding this comment.
This can be written a bit more simply: roundChangeMsgs.stream().map(SignedData::getAuthor).distinct().count()
There was a problem hiding this comment.
Nice...I didn't know about distinct()
rain-on
reviewed
Feb 26, 2019
| @@ -58,7 +59,8 @@ public boolean validateRoundChangeMessagesAndEnsureTargetRoundMatchesRoot( | |||
| final Collection<SignedData<RoundChangePayload>> roundChangeMsgs = | |||
| roundChangeCert.getRoundChangePayloads(); | |||
|
|
|||
| if (roundChangeMsgs.size() < quorum) { | |||
| if (roundChangeMsgs.stream().map(SignedData::getAuthor).collect(Collectors.toSet()).size() | |||
There was a problem hiding this comment.
we should create a test which validates the fix (which appears necessary!)
|
Replaced by #989 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The Round-Change-Certificate must contain at least Quorum(n) Round-Change messages sent by different validators
The current code does not verify this condition, but only that the Round-Change-Certificate contains at least Quorum(n) Round-Change messages sent by validators.
This PR fixes the issue.
Note: Tests must be added
Fixed Issue(s)