This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Make acceptance tests use the process based runner again #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding permissioning config file CLI option * Creating temp account whitelist file * Fixing bootnode/whitelist conflict
lucassaldanha
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Back when we upgraded Gradle the system property we set to indicate acceptance tests should use an external process when running pantheon stopped getting passed through to tests. Since then
ProcessPantheonNodeRunnerhasn't kept up with the CLI changes and new features required by tests.This fixes the system property so we use the process runner, will leave as a draft PR until all the tests are passing again.