FSFAT_SDCARD_INSTALLED - Accepted from mbed_app.json only #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2017 09:47
FSFAT_SDCARD_INSTALLED if present in SD library no test was actually tested. Using MBED_CONF_APP_FSFAT_SDCARD_INSTALLED or MBED_CONF_SD_FSFAT_SDCARD_INSTALLED, to allow this define to be used from app and lib json files.
geky
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSFAT_SDCARD_INSTALLED if present in mbed_lib.json which is default, is not accepted by tests.
Allowing FSFAT_SDCARD_INSTALLED define from mbed_lib.json and mbed_app.json files.
Changing erase command to trim in block device test
Issue was seen in #65