Change mutex to PlatformMutex #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geky - Please review |
geky
approved these changes
Nov 20, 2017
|
@geky - Lock/Unlock functions are not required, added just to have consistent code with mbed-os drivers. |
|
Hmm, I think most drivers have lock + unlock so that multiple consumers of the class can synchronize on hardware accesses. (Like SPI transactions). |
|
In that case, lock/unlock functions should be public right? |
|
I think the idea is you can extend the classes to provide a different synchronization interface. But for a non-transactional class each function is its own synchronization boundary. cc @c1728p9 for his thoughts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #69