Set output directory for derivative datasinks #914
Conversation
|
I just need to fix the datasink for the topup qc file. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 45.84% 45.86% +0.02%
==========================================
Files 65 65
Lines 9725 9729 +4
Branches 1063 1064 +1
==========================================
+ Hits 4458 4462 +4
Misses 5040 5040
Partials 227 227 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
is the pepolar_qc supposed to appear in this one?
There was a problem hiding this comment.
It looks like dsdti_topup is defined in the pytest markers but there's no corresponding test in the tests/ folder.
There was a problem hiding this comment.
Also, is it weird that dsdti_nofmap is creating this file?
There was a problem hiding this comment.
I think in the previous setup, DSDTI_nofmap downloaded data that had fieldmaps, then deleted those fieldmaps in a script. So this new nofmap is actually running with a pepolar fieldmap
There was a problem hiding this comment.
We should probably run both versions of the test and add a BIDS filter file to ignore the field maps in the nofmap test.
There was a problem hiding this comment.
I'd rather push that for a separate PR though.
There was a problem hiding this comment.
Just opened #916 for this.
Closes none.
Changes proposed in this pull request
base_directoryfor any datasinks to the output directory.desc-image_qc.csvtodesc-image_qc.tsv. This is a breaking change.topupcsv.csv(now calleddesc-pepolar_qc.tsv) to output directory.