Removed in-place inversion #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertMitjans
approved these changes
Feb 10, 2023
| (g.H(0).dagger(), qml.Hadamard(0).inv()), | ||
| (g.H(0).dagger().dagger(), qml.Hadamard(0).inv().inv()), | ||
| (g.H(0).dagger(), qml.adjoint(qml.Hadamard(0))), | ||
| (g.H(0).dagger().dagger(), qml.Hadamard(0)), |
There was a problem hiding this comment.
Would be nice to be consistent with the changes
Suggested change
| (g.H(0).dagger().dagger(), qml.Hadamard(0)), | |
| (g.H(0).dagger().dagger(), qml.adjoint(qml.adjoint(qml.Hadamard(0)))), |
There was a problem hiding this comment.
Same thing for all operations
There was a problem hiding this comment.
I did that before and the tests failed. If a pyquil gate is inverted multiple times, the code in pennylane_rigetti/converter.py:_is_inverted only checks whether a gate is inverted or not by counting the number of times a gate has been inverted and checking if the count is odd or even, so the cases where the pyquil gates have .dagger().dagger() should never have had .inv().inv() in the first place (which is the same as not doing anything anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all instances of in-place inversion with
qml.adjoint()