Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC80141 | Fix ReadTheDocs Build #153

Merged

Conversation

AndrewGardhouse
Copy link
Contributor

@AndrewGardhouse AndrewGardhouse commented Jan 20, 2025

Description of the Change:

Benefits:
RTD builds without errors, and the navbar from pennylane.ai (see https://xanaduai-pennylane--153.com.readthedocs.build/projects/strawberryfields/en/152/)

Possible Drawbacks:
N/A

Related GitHub Issues:
N/A

@AndrewGardhouse AndrewGardhouse marked this pull request as ready for review January 20, 2025 14:21
@@ -4,16 +4,12 @@ sphinx:
configuration: doc/conf.py

python:
install:
- requirements: requirements-ci.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea that we won't be running CI on this repo anymore?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewGardhouse correct me if I'm wrong but CI will still run. I think the idea is that all requirements for RTD should be encapsulated in doc/requirements.txt so installing requirements-ci.txt should not be needed.

@Alex-Preciado
Copy link

Force merging this now after our detailed discussion on Slack about the necessity of these changes. Thanks @AndrewGardhouse !!

@Alex-Preciado Alex-Preciado merged commit aa9f461 into master Jan 22, 2025
2 of 6 checks passed
@Alex-Preciado Alex-Preciado deleted the sc-80141-fix-readthedocs-build-for-xanaduai-pennylane branch January 22, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants