Remove more analytic occurrences
#1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
antalszava
changed the title
analytic occurencesanalytic occurrences
antalszava
commented
Apr 30, 2021
Comment on lines
-43
to
-44
| shots = 1000 | ||
| analytic = true |
There was a problem hiding this comment.
TOML doesn't seem to have the concept of None (see here), so just leaving shots out instead of shots=None.
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 146 146
Lines 11050 11050
=======================================
Hits 10842 10842
Misses 208 208 Continue to review full report at Codecov.
|
josh146
approved these changes
Apr 30, 2021
Comment on lines
-43
to
-44
| shots = 1000 | ||
| analytic = true |
Co-authored-by: Josh Izaac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more places where
analyticappeared:DeviceError: The analytic argument has been replaced by shots=None. Please use shots=None instead of analytic=True.There was another which made me wonder:
./pennylane/optimize/shot_adaptive.py: if dev.analytic:(check_devicemethod). @josh146 would this be intended becauseDevice.analyticis still valid?