Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Add Catalyst ctrl #4726

Merged
merged 41 commits into from
Nov 29, 2023
Merged

[Compiler] Add Catalyst ctrl #4726

merged 41 commits into from
Nov 29, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Oct 24, 2023

Description of the Change:

This PR adds support for QJIT compatible qml.ctrl.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@rmoyard rmoyard changed the title [Compiler] Catalyst ctrl [Compiler] Add Catalyst ctrl Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35a34e6) 99.65% compared to head (c63ea7d) 99.64%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4726      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.02%     
==========================================
  Files         387      387              
  Lines       34960    34703     -257     
==========================================
- Hits        34840    34580     -260     
- Misses        120      123       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmoyard
Copy link
Contributor Author

rmoyard commented Oct 25, 2023

[sc-46404]

@maliasadi maliasadi requested review from josh146 and dime10 October 27, 2023 16:32
@rmoyard rmoyard requested a review from maliasadi October 27, 2023 17:46
pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved
tests/test_compiler.py Outdated Show resolved Hide resolved
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @rmoyard! Just one fix in the docstring but otherwise looking good.

pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved
Co-authored-by: Josh Izaac <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved
pennylane/ops/op_math/controlled.py Show resolved Hide resolved
tests/test_compiler.py Show resolved Hide resolved
Co-authored-by: Matthew Silverman <[email protected]>
Base automatically changed from maa/integrate-catalyst-2 to master November 28, 2023 17:25
@rmoyard rmoyard enabled auto-merge (squash) November 29, 2023 16:23
@rmoyard rmoyard requested a review from maliasadi November 29, 2023 17:43
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved
@rmoyard rmoyard merged commit c7cda37 into master Nov 29, 2023
34 checks passed
@rmoyard rmoyard deleted the catalyst_ctrl branch November 29, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants