Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate gradient_transform #4794

Closed
wants to merge 3 commits into from
Closed

Conversation

timmysilv
Copy link
Contributor

Context:
after #4774 was merged, @albi3ro realized we should have deprecated gradient_transform as well.

Description of the Change:
Deprecate gradient_transform which is no longer used

Benefits:
gradient_transform is closer to being removed.

Possible Drawbacks:
N/A

@timmysilv timmysilv requested a review from a team November 6, 2023 20:14
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b2caab) 99.64% compared to head (69ae057) 99.64%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4794      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files         381      381              
  Lines       34302    34048     -254     
==========================================
- Hits        34181    33926     -255     
- Misses        121      122       +1     
Files Coverage Δ
pennylane/gradients/gradient_transform.py 100.00% <ø> (ø)
pennylane/transforms/batch_transform.py 96.03% <100.00%> (+0.03%) ⬆️
pennylane/transforms/compile.py 100.00% <ø> (ø)
pennylane/transforms/op_transforms.py 100.00% <100.00%> (ø)
pennylane/transforms/qfunc_transforms.py 90.74% <100.00%> (+0.74%) ⬆️

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timmysilv
Copy link
Contributor Author

gradient_transform is not even rendered... it was silently removed already

@timmysilv timmysilv closed this Nov 6, 2023
@timmysilv timmysilv deleted the deprecate-gradient-transform branch February 2, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants