Deprecate QauntumScript.output_dim
#6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6577 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 454 454
Lines 43262 43264 +2
=======================================
+ Hits 42959 42961 +2
Misses 303 303 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Nov 13, 2024
albi3ro
reviewed
Nov 13, 2024
albi3ro
reviewed
Nov 13, 2024
albi3ro
reviewed
Nov 13, 2024
JerryChen97
commented
Nov 13, 2024
JerryChen97
commented
Nov 13, 2024
JerryChen97
commented
Nov 13, 2024
lillian542
reviewed
Nov 13, 2024
Co-authored-by: lillian542 <[email protected]>
JerryChen97
commented
Nov 13, 2024
JerryChen97
commented
Nov 13, 2024
JerryChen97
commented
Nov 13, 2024
JerryChen97
added a commit
that referenced
this pull request
Jan 15, 2025
**Context:** The property `output_dim` of `QuantumScript` has been deprecated in previous round, [sc-74594] #6577. Now we would love to remove it entirely. **Description of the Change:** - Remove property `output_dim` along with its tests, warnings, etc. - Remove the detached attribute `_output_dim` after previous removal. - Remove the detached private method `_update_output_dim` which used to be strictly only helping update property `output_dim`. **Benefits:** Cleaner codebase with less redundancies. **Possible Drawbacks:** Not known. Perhaps some nuances hidden in some uncovered cornercase tests. Anyways potential drawback won't affect any current feature in principle. **Related GitHub Issues:** [sc-82150] --------- Co-authored-by: lillian542 <[email protected]>
willjmax
pushed a commit
that referenced
this pull request
Feb 4, 2025
**Context:** The property `output_dim` of `QuantumScript` has been deprecated in previous round, [sc-74594] #6577. Now we would love to remove it entirely. **Description of the Change:** - Remove property `output_dim` along with its tests, warnings, etc. - Remove the detached attribute `_output_dim` after previous removal. - Remove the detached private method `_update_output_dim` which used to be strictly only helping update property `output_dim`. **Benefits:** Cleaner codebase with less redundancies. **Possible Drawbacks:** Not known. Perhaps some nuances hidden in some uncovered cornercase tests. Anyways potential drawback won't affect any current feature in principle. **Related GitHub Issues:** [sc-82150] --------- Co-authored-by: lillian542 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This property is now slightly wrong, and is only used by
parameter_shift_cv.py.Description of the Change:
qml.tape.qscript.py::QuantumScripttest_qscript.pytest_tape.pyandtest_legacy_device.pyqml.gradients.parameter_shift_cv.pywhich is the only module using this propertyBenefits:
Possible Drawbacks:
Potential uncovered usecases of this property inside or outside PL
Related GitHub Issues:
Related Shortcut Stories:
[sc-74594]