-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove string support for control_values
of MutliControlledX
#6835
Remove string support for control_values
of MutliControlledX
#6835
Conversation
…ntrolledX
…ntrolledX
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6835 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 476 476
Lines 45183 45182 -1
==========================================
- Hits 45006 45002 -4
- Misses 177 180 +3 ☔ View full report in Codecov by Sentry. |
Spotted deprecated usages in lightning https://github.com/PennyLaneAI/pennylane-lightning/pull/1040/files |
Another open PR from qml used deprecated interface, although it seems long time unmaintained. PennyLaneAI/qml#386 (comment) |
That PR hasn't been touched in 2 years, no need to worry about it :) |
Lightning fix merged. We set this removal as auto-merge now. |
…ntrolledX
Co-authored-by: Astral Cai <[email protected]>
…ntrolledX
Context:
In PL0.36 we deprecated the string type support for argument
control_values
of the operatorMultiControlledX
initialization, e.g.control_values='01'
shall not be allowed anymore. In this PR we would like to remove this entirely with a strict type check.Description of the Change:
isinstance
to raiseValueError
if thecontrol_values
does not follow the designed pattern.Benefits:
Less redundancy
Possible Drawbacks:
Potential existence of uncovered indirect usage of string input in
MultiControlledX
Related GitHub Issues:
[sc-81527]