Deprecate MeasurementProcess.return_type
and ObservableReturnTypes
#6841
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The
MeasurementProcess.return_type
is only used by the legacy device in a chain ofif mp.return_type.name is ...
checks that can easily be replaced withisinstance
checks.In PL0.40,
return_type
is a property ofMeasurementProcess
which returns None only. Meanwhile,ObservableReturnTypes
is an Enum that defines and wraps the name strings, redundantly.Description of the Change:
return_type
.return_type
with directisinstance
checkObservableReturnTypes
with direct definitions.Benefits:
Less redundancies.
Possible Drawbacks:
any downstreaming usage of the deprecations:
Related GitHub Issues:
[sc-71892]