[Capture] First PR for enabling dynamic decompositions with PLxPR enabled
#6859
+640
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
PietropaoloFrisoni
changed the title
qml.cond in decompositions can be captured into PLxPRPLxPR enabled
…o cond_dynamic_decomp
…o cond_dynamic_decomp
…o cond_dynamic_decomp
…o cond_dynamic_decomp
…o cond_dynamic_decomp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6859 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 480 480
Lines 45495 45504 +9
=======================================
+ Hits 45310 45319 +9
Misses 185 185 ☔ View full report in Codecov by Sentry. |
PietropaoloFrisoni
changed the title
PLxPR enabledPLxPR enabled
…o cond_dynamic_decomp
…o cond_dynamic_decomp
mudit2812
reviewed
Feb 3, 2025
tests/capture/transforms/test_capture_dynamic_decompositions.py
Outdated
Show resolved
Hide resolved
Comment on lines
215
to
223
| @staticmethod | ||
| def _compute_plxpr_decomposition(phi, wires): | ||
|
|
||
| if phi > 0.5: | ||
| qml.RX(phi, wires=wires) | ||
|
|
||
| else: | ||
| qml.RY(phi, wires=wires) | ||
|
|
There was a problem hiding this comment.
For this to work, don't you need to set autograph=True in the call to make_plxpr in _plxpr_decomposition?
…o cond_dynamic_decomp
albi3ro
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The main purpose of this story is to implement a prototype for dynamic decompositions in PL with program capture enabled.
At this stage, we only focus on one-level dynamic decompositions (without implementing additional parameters that can be passed to the interpreter). The UI might change in the future.
Therefore, these are the main current limitations of the prototype introduced in this PR:
Description of the Change: As above.
Benefits: We can start capturing the decompositions dynamically with program capture enabled instead of simply returning the operators list at the end.
Possible Drawbacks: Still experimental. It shouldn't cause issues with the current program capture scaffolding.
Related GitHub Issues: None
Related Shortcut Stories: [sc-82690]