Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface-unit-tests.yml handling of pytest warnings #6880

Merged
merged 41 commits into from
Feb 3, 2025
Merged

Conversation

mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Jan 24, 2025

CI is hiding deprecation warnings, because the use of -W (introduced to support the warnings-as-errors workflow) overrides pytest.ini. This PR moves the creation of the pytest arg to a separate job, and uses the output of this job as the pytest arg. This way, we can avoid using -W altogether if the warnings-as-errors workflow isn't running.

[sc-83043]

@mudit2812 mudit2812 requested a review from rashidnhm January 24, 2025 16:52
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@rashidnhm rashidnhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries on the CI changes on the PR. Though I suspect failures to crop up on this PR due to deprecation warnings that may have been suppressed due to this.

I leave fixing that to the PL team, approving within the context of CI changes

@mudit2812
Copy link
Contributor Author

mudit2812 commented Jan 24, 2025

Going to run the warnings-as-errors workflow to see if it works as expected as well. Run linked here.

@mudit2812 mudit2812 marked this pull request as draft January 24, 2025 17:32
@mudit2812 mudit2812 marked this pull request as ready for review January 24, 2025 17:51
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (0ed7395) to head (1ba716a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6880   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         479      479           
  Lines       45399    45399           
=======================================
  Hits        45215    45215           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrijapau andrijapau added the do not merge ⚠️ Do not merge the pull request until this label is removed label Jan 27, 2025
@andrijapau andrijapau self-assigned this Jan 27, 2025
@andrijapau andrijapau changed the title Update interface-unit-tests.yml pytest warning level handling Update interface-unit-tests.yml handling of pytest warnings Jan 27, 2025
@andrijapau andrijapau removed the do not merge ⚠️ Do not merge the pull request until this label is removed label Jan 30, 2025
@andrijapau andrijapau requested a review from astralcai January 30, 2025 20:17
@JerryChen97
Copy link
Contributor

After we make sure no unexpected warnings from return_type, I guess it will be better to add labels of full CI and GPU to this PR

@andrijapau andrijapau added ci:run-full-test-suite Run the full test-suite on the pull request gpu labels Feb 3, 2025
@andrijapau andrijapau enabled auto-merge (squash) February 3, 2025 18:10
@andrijapau andrijapau merged commit 8487ec0 into master Feb 3, 2025
71 checks passed
@andrijapau andrijapau deleted the wae-fix branch February 3, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:run-full-test-suite Run the full test-suite on the pull request gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants