-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update interface-unit-tests.yml
handling of pytest
warnings
#6880
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries on the CI changes on the PR. Though I suspect failures to crop up on this PR due to deprecation warnings that may have been suppressed due to this.
I leave fixing that to the PL team, approving within the context of CI changes
Going to run the warnings-as-errors workflow to see if it works as expected as well. Run linked here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6880 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 479 479
Lines 45399 45399
=======================================
Hits 45215 45215
Misses 184 184 ☔ View full report in Codecov by Sentry. |
interface-unit-tests.yml
handling of pytest
warnings
After we make sure no unexpected warnings from |
Co-authored-by: Astral Cai <[email protected]>
CI is hiding deprecation warnings, because the use of
-W
(introduced to support thewarnings-as-errors
workflow) overridespytest.ini
. This PR moves the creation of the pytest arg to a separate job, and uses the output of this job as the pytest arg. This way, we can avoid using-W
altogether if the warnings-as-errors workflow isn't running.[sc-83043]