Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune redundant replace from execution.py #6894

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Jan 28, 2025

Context:

Removes unnecessary replace that survived after some updates made in #6822. This code just redundantly sets the interface and derivative_order right after it is set a bit earlier.

Benefits: Neater code.

Possible Drawbacks: None.

This comment was marked as off-topic.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (c813d30) to head (14f62fb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6894      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files         478      478              
  Lines       45309    45306       -3     
==========================================
- Hits        45127    45124       -3     
  Misses        182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrijapau andrijapau changed the title Prune unnecessary code from execution.py Prune redundant replace from execution.py Jan 28, 2025
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up! 🧹

@andrijapau andrijapau merged commit 06cd2f0 into master Jan 28, 2025
47 checks passed
@andrijapau andrijapau deleted the clean-up-workflow branch January 28, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants