-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qml.capture.pause
#6911
Add qml.capture.pause
#6911
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6911 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 480 480
Lines 45474 45495 +21
=======================================
+ Hits 45289 45310 +21
Misses 185 185 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, just a couple of questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Context:
I was getting annoyed by all the times I was doing:
Description of the Change:
Adds
qml.capture.stop_recording()
Benefits:
I get less annoyed. Also, code might be more clean and readable.
Possible Drawbacks:
Related GitHub Issues: