Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Capture] add eval_jaxpr method to null.qubit #6924

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Feb 4, 2025

Context:

I'm starting to some information about the pros and cons of program capture and how to use it.

I'd like to just demonstrate some basics about the classical overheads and scaling, and would like to use null.qubit to do so.

Description of the Change:

Adds an eval_jaxpr method to null.qubit.

Benefits:

We can examine the classical overheads associated with null.qubit.

Screenshot 2025-02-04 at 3 04 51 PM

Possible Drawbacks:

Related GitHub Issues:

[sc-83829]

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (53df3dc) to head (0cb55de).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6924   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         480      480           
  Lines       45496    45505    +9     
=======================================
+ Hits        45311    45320    +9     
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise ready to approve.

tests/devices/test_null_qubit.py Outdated Show resolved Hide resolved
@albi3ro albi3ro requested review from mudit2812 and lillian542 and removed request for PietropaoloFrisoni February 5, 2025 16:43
@albi3ro albi3ro requested a review from andrijapau February 7, 2025 16:36
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@albi3ro albi3ro enabled auto-merge (squash) February 7, 2025 17:43
@albi3ro albi3ro merged commit 0ecf816 into master Feb 7, 2025
46 checks passed
@albi3ro albi3ro deleted the null-qubit-jaxpr branch February 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants