Fixing ISS-543 by appending a new body json interface. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`public func bodyJSON<T: Decodable>(_ type: T.Type) -> T?`
|
SMTP has its own repo now, so we can remove it from the tests. |
kjessup
reviewed
Jan 17, 2018
Sources/CURLResponse.swift
Outdated
| @@ -300,6 +301,9 @@ public extension CURLResponse { | |||
| /// Get the response body decoded from JSON into a [String:Any] dictionary. | |||
| /// Invalid/non-JSON body data will result in an empty dictionary being returned. | |||
| public var bodyJSON: [String:Any] { do { return try bodyString.jsonDecode() as? [String:Any] ?? [:] } catch { return [:] } } | |||
| /// Get the response body decoded from JSON into a decodable structure | |||
| /// Invalid/non-JSON body data will result in nil | |||
| public func bodyJSON<T: Decodable>(_ type: T.Type) -> T? { do { return try JSONDecoder().decode(type, from: Data(bytes: bodyBytes)) } catch { return nil } } | |||
There was a problem hiding this comment.
I think this should throw whatever the JSONDecoder throws. Instead of squelching the problem and giving no feedback. Users can always get this nil return behaviour by using try?.
There was a problem hiding this comment.
Adding this func is a good way to solve this one. Nice.
There was a problem hiding this comment.
The first thought was to throw but I changed my mind after reading public var bodyJSON ... surely I would like to throw!!! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public func bodyJSON<T: Decodable>(_ type: T.Type) -> T?