-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty big update #38
Conversation
For better uniformity on FilterLists.com and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great!
I do know how to write adblock lists but I dont want to maintain them here if I dont really need them.. :)
Why I do not use AGH? I would like to know what |
Hmm, let's see... I will admit as much that AdGuard Home is essentially a company product, or more like a company *by-*product, as it appears to me to have been created out of earlier work they did on AdGuard DNS and AdGuard for Android, which are most definitely corporate-made products. "Per-device configuration" is done at several levels and settings menus, but are not quite as separational as one would've thought. Essentially, if an IP address has been assigned a nickname in "Client settings", certain settings can be modified specifically for them that can differ from the global settings, such as whether to use:
I have only the most bare-basic of experiences with Pi-Hole, but my experience is that AGH has two big advantages:
Once the AGH installation .exe has been downloaded from GitHub, the installation process goes fairly easy, the resulting browser GUI looks nice, and the query system works well for me. It even has native versions for Windows, macOS, and FreeBSD, and it's technically installable on some routers (though the RAM requirements for that are lofty by router standards). The official documentations for AGH are unfortunately often outdated by a few months (as can be seen in the ≥200 open issue reports), and there's a number of mostly surpassable oversights that the team haven't really had time to fix yet (e.g. to become able to search the query by client nickname; achieving better support for EasyList lists by not discarding entries that use Once one has got a bit more used to AGH and would want to delve deeper into the settings, it does have native support for DNS-over-HTTPS and DNS-over-TLS, support for preventing certain IP addresses from using your server (though without 3rd-party list support for such), it's much easier to make use of non-localhost hosts files for e.g. Chinese censorship circumvention than in Pi-Hole, an optional DHCP server function, and a few other things. AdGuard Home's other main advantage, is that it supports adblocker-syntax blocking rules, although only a very narrow subset. It supports the use of,
If you have any other questions, I'd be more than willing to help answering them. |
Thank you for the comparison, this is really the best explanation than any other I could find online. |
Okay, so the situation is that AdGuard Home is now seemingly doing an open rollcall for new lists to include in stock installations. Additionally, I became aware of some problems involving the Deezer smart-TV app and of a way to block LG TVs' ridiculous connection attempts to garbled domains, so I went for a twofer, and decided to fix the entries in your Pi-hole list version and to create an AGH list version on top of that, spending three days on the preparations.
Complete changelog:
tv.deezer.com
, as it causes an error message when starting up Deezer's TV app.I understand it as such that you have virtually zero experience with AdGuard Home, or for that matter with writing lists for ordinary adblockers like uBlock Origin, so I will volunteer to help you out with the AGH list version to begin with if you ever need my help with it for anything whatsoever, in exchange for being credited in its metadata. The biggest difference is that AGH can do blacklisting, whitelisting and RegEx in the same list, which I understand it as such that Pi-hole can't.
I took a considerably more conversative P-H→AGH conversion approach than I did in #26, especially when it came to the Samsung entries, if that helps sweeten my proposal somewhat.
Should this pull request become accepted, I would give very warm recommendations to the AGH team to include the AGH list version in it, although I do not have the final say on their decisions.