Test/e2e/alert #357
Merged
Test/e2e/alert #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the contentDescription of Product and urgency. - Used index to sign each MyAlertItem and PalsAlertItem.
- Use while and sleep to wait for screens to be loaded. - Use randomNumber to prevent parallel testing failures. - Removed unnecessary set up of alert VM. - Added checks after edit and delete.
…test/e2e/alert # Conflicts: # app/src/main/java/com/android/periodpals/ui/alert/AlertLists.kt
…test/e2e/alert # Conflicts: # app/src/main/java/com/android/periodpals/ui/alert/AlertLists.kt
…test/e2e/alert # Conflicts: # app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndM1.kt
…test/e2e/alert # Conflicts: # app/src/main/java/com/android/periodpals/ui/alert/AlertLists.kt # app/src/test/java/com/android/periodpals/ui/alert/AlertListsScreenTest.kt
Closed
5 tasks
|
charliemangano
approved these changes
Dec 20, 2024
| @@ -292,9 +293,10 @@ fun AlertListsScreen( | |||
| if (myAlertsList.isEmpty()) { | |||
| item { NoAlertDialog(context.getString(R.string.alert_lists_no_my_alerts_dialog)) } | |||
| } else { | |||
| items(myAlertsList) { alert -> | |||
| itemsIndexed(myAlertsList) { index, alert -> | |||
| @@ -352,6 +356,7 @@ fun AlertListsScreen( | |||
| * profile picture, time, location, product type, urgency, and an edit button. | |||
| * | |||
| * @param alert The alert to be displayed. | |||
| * @param indexTestTag The index of the alert in the list. | |||
coaguila
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alert E2E
Description
This PR introduces an end-to-end test for the flow of creating an alert and editing it and deleting it.
Changes
AlertLists.kt, because using the alert.id in the test tag was not possible from the end to end.Files
Added
Modified
AlertLists.ktAlertListsScreenTestRemoved
None.
Dependencies Added
None.