-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump IO.pm version to 1.51, due to PR 19663 #20201
Conversation
Would probably be good to sync all of the IO versions at 1.51 |
I notice that each of my 10 commit messages from yesterday begin with the "=" sign. |
On Fri, 2 Sept 2022 at 13:02, sisyphus ***@***.***> wrote:
I notice that each of my 10 commit messages from yesterday begin with the
"=" sign.
I normally specify my commits using --file=msg.txt, but this time I went
with -m="the message".
I'm guessing I should not have used the "=" sign with the -m option.
Anyway - I hope that can be overlooked, and I'll try to remember to always
use the --file option in future.
If they have not been merged yet fixing this is relatively easy, just use
git rebase --interactive and the "reword" option.
Yves
…--
perl -Mre=debug -e "/just|another|perl|hacker/"
|
I would also ask that you squash these 11 commits into one (with corrected message). For two reasons: (1) There's a common logic to all of them. (2) When, in the future, we have to bisect the core repository in search of a build or test failure, other things being equal it's better to have a smaller number of commits in the bisection range. With these updates this p.r. will be mergeable, IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in comments, please squash commits and correct commit message.
Offhand, I don't know how to do any of the things being requested. I'll continue to plug away, and I'll probably get there eventually - though I think it will come in the form of a fresh PR and the closure of this one. The only reasons I created this PR are that:
That seemed like just the job for a person of my very limited git capability. Cheers, |
On Sun, 4 Sept 2022 at 07:44, sisyphus ***@***.***> wrote:
Offhand, I don't know how to do any of the things being requested.
I suspect that I'm a long way off being able to use --interactive. (I
haven't tested, but I gather that it's going to want me to select a
suitable text editor - which I probably don't have, and won't know how to
use even if I do have one.)
yes it likely will on windows.
I don't use git; I don't like git; I find it inherently uninteresting; and
I doubt that I'm clever enough to make intelligent use of it, anyway.
I don't buy that last point for a minute. I have interacted with you too
many times to accept that argument. Sorry.
I don't presently know how to "squash these 11 commits into one", but my
inkling is that even I will be able to master that bit.
I'll continue to plug away, and I'll probably get there eventually -
though I think it will come in the form of a fresh PR and the closure of
this one.
In the meantime, if someone has the desire and opportunity to fix this PR
up, they are welcome to do so.
Or, if someone wants to spend the 10 minutes it will probably take them to
prepare a fresh PR for this, then I would urge them to do so, as I'm more
than happy to close this.
The only reasons I created this PR are that:
1. I, by chance, noticed the oversight;
2. It was one of my (merged) PRs that had failed to update IO.pm
version in the first place;
3. It called for the simplest of changes to one file.
That seemed like just the job for a person of my very limited git
capability.
What could possibly go wrong !! ;-)
Ill save you the lecture on craftsmen and tools and show you one way you
could do it: ;-)
To squash it all down one way would be
git checkout $topic_branch
git fetch
git rebase origin/blead
git reset origin/blead
git commit -a -m'....'
git push -f
There are actually shorter recipes, but i wanted you to see the basics.
If this really is a problem contact me off list and ill sort it for you.
cheers,
Yves
…--
perl -Mre=debug -e "/just|another|perl|hacker/"
|
I'm still pretty good at doing copy'n'paste ;-) Fingers crossed. Cheers, |
Branch locally rebased on blead, tested, merged to blead, re-tested, pushed. Closing ticket. |
@jkeenan, I had expected that this PR would simply have been merged - rather than subjected to the procedure you outlined. |
IIUC, #19663 should have bumped IO.pm to version 1.51, because of the alteration it made to dist/IO/poll.h.
But this was overlooked.
Consequently, blead has IO at version 1.50 and CPAN has IO at version 1.50, but they contain different IO/poll.h files.
This PR is intended to correct the earlier oversight.
Cheers,
Rob