Support for Android 13 and small corrections #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter-St
reviewed
Dec 19, 2023
| @@ -9,7 +9,7 @@ if (keystorePropertiesFile.exists()) { | |||
| } | |||
|
|
|||
| android { | |||
| compileSdk = 34 | |||
| compileSdk 33 | |||
There was a problem hiding this comment.
Is it required to drop down the SDK version to 33?
Are there any ways to keep SDK 34 and run it successfully on Android 13 devs?
|
I welcome your decision to commit to Android 13 permissions in the Repo. |
|
I believe I had an older gradle with 28, and put 33. I can test 34 today no problem. This should technically allow android 14 users as well, but Samsung has not released an official upgrade in the US for the tab s8 for me to test it. |
|
As expected SDK 34 no issues on a 13 device. |
|
Thx for the conformation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Android 7 DJI Smart Controller, and Samsung Tab S8 Ultra.