Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate native contract #596

Merged
merged 22 commits into from
Jan 17, 2022
Merged

Instantiate native contract #596

merged 22 commits into from
Jan 17, 2022

Conversation

kvinwang
Copy link
Collaborator

@kvinwang kvinwang commented Dec 13, 2021 •
edited
Loading

The PR implement native contract instantiation.

@kvinwang kvinwang requested review from shelvenzhou and h4x3rotab and removed request for shelvenzhou December 13, 2021 11:48
@kvinwang kvinwang mentioned this pull request Dec 13, 2021
Closed
h4x3rotab
h4x3rotab reviewed Dec 17, 2021
View reviewed changes
crates/phactory/src/contracts/support.rs Outdated Show resolved Hide resolved
crates/phactory/src/system/mod.rs Outdated Show resolved Hide resolved
crates/phactory/src/system/side_tasks/geo_probe.rs Show resolved Hide resolved
crates/phactory/src/contracts/pink.rs Outdated Show resolved Hide resolved
Base automatically changed from pink-key-manage to master December 28, 2021 03:28
@kvinwang kvinwang marked this pull request as draft January 4, 2022 09:25
@shelvenzhou shelvenzhou mentioned this pull request Jan 6, 2022
Merged
9 tasks
@kvinwang kvinwang marked this pull request as ready for review January 8, 2022 02:07
@kvinwang kvinwang requested a review from h4x3rotab January 8, 2022 02:07
h4x3rotab
h4x3rotab reviewed Jan 17, 2022
View reviewed changes
crates/phactory/src/system/mod.rs
@@ -483,7 +488,34 @@ impl<Platform: pal::Platform> System<Platform> {
contract.handle_query(origin, req, &mut context)
}

pub fn process_messages(&mut self, block: &mut BlockInfo) -> anyhow::Result<()> {
pub fn process_next_message(&mut self, block: &mut BlockInfo) -> anyhow::Result<bool> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the return value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        loop {
            match self.process_next_message(block) {
                Err(err) => {
                    error!("Error processing message: {:?}", err);
                }
                Ok(no_more) => {
                    if no_more {
                        break;
                    }
                }
            }
        }

@kvinwang kvinwang merged commit 1c740ad into master Jan 17, 2022
@kvinwang kvinwang deleted the instantiate-native branch January 17, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h4x3rotab h4x3rotab h4x3rotab approved these changes

@shelvenzhou shelvenzhou Awaiting requested review from shelvenzhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvinwang @h4x3rotab