Object rotation on 'E' Holding (Additional Feature)

[frendship-loost]

Hello,

Many games with physics interactivity using a FPS perspective have some way to more finely handle objects while holding them. In COGITO, having a system for players to reliably rotate objects would be very useful to polish this physics holding feature. For both in-game player experience to recover from physics objects falling over, and for developers to more robustly utilize physics objects in their projects.

In the current implementation, you simply press 'E' on a valid physics object to pick it up and hold. I propose that while having an object held, holding Mouse2 would allow mouse movement to orbit the rotation of the held object, overriding player mouse-look while performing this action. Releasing Mouse2 should lock the object's rotation, and re-enable player mouse-look again.

Some edge case scenarios should be thought of; cases where maybe the player drops the object while in rotation mode, or a weight limit threshold to where the player can't rotate huge+heavy objects, for examples.

I don't have the confidence myself to put together the code for this, or thoroughly bug-test it for a pull request. I hope that I explained my thoughts here clearly enough and that others also think this is a worthwhile idea :)

[Phazorknight]

Hey,
Yeah, was considering this as well at some point. Could be something to add to the CarryableComponent.
Will see if I get around to add this to it (and how to make it work with gamepad as well).

[Phazorknight]

Hey @frendship-loost ,

I've just pushed a first implementation of this feature in 2821a4d

Read the commit notes for more details.

Some things to note:

• I've chosen the action_secondary input action instead of 'E' as E is default for main interaction (pickup/carry/drop etc), this could cause conflicts or confusion.
• Rotating is done with WASD / left joystick. I've picked this instead of mouse input to ensure it's gamepad compatible.

[frendship-loost]

I'll check this out soon! I think that your changes make sense.

It is a minor polish, but has a big impact on user experience I think.