Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling mistakes in Lobby scene hints #132

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

samaritan-sw
Copy link
Contributor

Hi, first of all - very cool project! :)

My humble contribution: I've found some spelling mistakes across demo hints in the lobby scene, so I've cleaned them up, rephrased some small bits, and split up some paragraphs in a way that makes a bit more sense visually.

Cheers!

Copy link

@inertaert inertaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just a random guy on GitHub, but I agree that these small changes greatly improve readability and think @Phazorknight should approve them.

One minor note: The addition made at #L7436-L7447 should probably be made directly to the default text in DemoPrefabs/cogito_demo_hint.tscm instead:

readable_content = "You've found a Demo Hint!
These contain explanations on how objects in this scene are set up.
This hint is an example of using ReadableComponent.
A ReadableComponent is an InteractionComponent that makes objects \"readable\". On interacting, a window like this will pop up, displaying a text.
To create your own, attach a ReadableComponent to an Cogito Object and set the desired title, text and sound.
As with any InteractionComponent, you can also customize with input_map_action is used and what prompt is displayed. In this case it is \"Read hint\".
To close this window, either press the interaction button again or press ESC."

Nice work in any case.

Best regards.

@samaritan-sw
Copy link
Contributor Author

Hi @inertaert, thanks for your feedback!

You're right, I didn't realise the demo hint had its Readable Content property set inside its own scene - that should be correct now.

Copy link
Owner

@Phazorknight Phazorknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for these!

I can only use "english isn't my native language" for so long, really need to run stuff through a grammar and spell check before committing. 😅

@Phazorknight Phazorknight merged commit 911483f into Phazorknight:main Apr 1, 2024
@samaritan-sw
Copy link
Contributor Author

@Phazorknight I'll tell you a little secret...it's not my native language either! 😅 So take my submissions with a grain of salt...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants