Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "is_carryable_while_wielding" property #139

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

samaritan-sw
Copy link
Contributor

I find it a little tedious having to put away my weapon in order to carry something as small as a battery or a potion. I think it would be better to leave devs with an easy option to disable this for lighter items or across all items entirely.

To that end, I've implemented a really simple bool property in CarryableComponent.gd which lets you toggle this behaviour. Of course, in what I believe to be the spirit of the plugin, I think we can let users worry about the intricacies of their own implementations (in terms of handling potential collision issues between the viewmodel and the carried object if the carry distance is really close for example).

I've tested this and have found no immediate issues but maybe there is a technical reason why this restriction was in place?

Copy link
Owner

@Phazorknight Phazorknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
I think this implementation makes the most sense, enabling devs to define which objects can be carried while wielding.

@Phazorknight Phazorknight merged commit 44ae181 into Phazorknight:main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants