Add "is_carryable_while_wielding" property #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it a little tedious having to put away my weapon in order to carry something as small as a battery or a potion. I think it would be better to leave devs with an easy option to disable this for lighter items or across all items entirely.
To that end, I've implemented a really simple bool property in CarryableComponent.gd which lets you toggle this behaviour. Of course, in what I believe to be the spirit of the plugin, I think we can let users worry about the intricacies of their own implementations (in terms of handling potential collision issues between the viewmodel and the carried object if the carry distance is really close for example).
I've tested this and have found no immediate issues but maybe there is a technical reason why this restriction was in place?