Instantiate nodes using position instead of global_position #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where every time a node is set to spawn upon another's death, or a spawner is used, a non-fatal error message "Condition !is_inside_tree is true" pops up.
Repro steps: shoot a target in any scene and the error will pop up in the console.
I believe this is due to adding the child to the tree before setting its global_position property. Unfortunately, setting the global_position before adding the child to the tree seems to prevent the node from showing (or at least from spawning in the right position).
Using "position" to instantiate the nodes seems to fix this, and I've observed no change in behaviour - however this solution might not follow best practice, so people more familiar with the engine should feel free to come up with something better if needed.