Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/wieldable decouple #151

Merged

Conversation

brian-holsters
Copy link
Contributor

@brian-holsters brian-holsters commented Apr 6, 2024

fixes #150

Copy link
Owner

@Phazorknight Phazorknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a change to Throwables defaulting to the pickup scene as the projectile. otherwise this looks solid.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projectile spawning:
I would not default to the projectile prefab being the same as the pickup item.
I can see cases where devs might want a the spawned projectile be a different scene than the pickup-item
(items which thrown state would differ from their pickup item state, something like armed grenades for example).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved by adding an optional export to the wieldable script, here's a video of it working:

https://streamable.com/i9i99n

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's a very nice solution.

@Phazorknight Phazorknight merged commit c0ad88c into Phazorknight:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple Wieldables from player scene
2 participants