Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footstep sounds in sync with head wobble, wobble intensity is adjustable #161

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

BrodyB
Copy link
Contributor

@BrodyB BrodyB commented Apr 13, 2024

Started working on a game that uses Cogito as a base, and these seemed like good general enhancements I could bring back in.

  1. Footstep sounds no longer use a timer and instead trigger when the head wobble sine value goes over 0.9, ensuring headbob and footsteps are in sync.
  2. Headbob intensity values are exposed, and adjusting the headbob settings scale the intensity only. This way footsteps have a consistent interval across settings.
  3. Headbob settings are now Full (100%), Average (70%), and Minimal (10%). Though maybe there should be an Off setting (0%)?

BrodyB added 3 commits April 13, 2024 15:39
…p playback

The intention here is to make sure the footsteps always play in sync with headbob, even if headbob is low or non-existant.
Copy link
Owner

@Phazorknight Phazorknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Definitely a nice improvement.

In terms of headbob settings: I think having at least a small amount helps quite a bit with the feel and avoids the "floatiness". If a dev wants one of the settings to be off, it's easy to change.

@Phazorknight Phazorknight merged commit 8b78c38 into Phazorknight:main Apr 14, 2024
@BrodyB BrodyB deleted the headbob_step_sync branch July 21, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants