Fixes some player's physics issues. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah, thanks so much for this. It's gonna take me a hot minute to fully check and test this. |
Update stair stepping, now it's more compatible with Godot Jolt New node added to player as body for rotation instead of using player's collision, useful for player with box collision Separation of computed velocity from move_and_slide's velocity Update save/load of body rotation in player state
mrezai
force-pushed
the
improve-player-physics-2
branch
from
a13fde4 to
00cbc01
Compare
|
Sorry I forgot to update save/loading of rotation in player state. I add it to current PR. |
Phazorknight
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update stair stepping, now it's more compatible with Godot Jolt, previous code is a port of my Godot 3.5 implementation and new code added from updated version of main repository: https://github.com/mrezai/GodotStairs
New node added to player as body to handle rotation instead of using player's collision, useful for player with box collision(prevent player from unwanted fall on ledges).
Separation of computed velocity from move_and_slide's velocity, previous code cause unwanted damage to player for example after jump on objects.