Fall/Jump Landing Audio #253
Conversation
Materials based landing audio player, uses same logic as the Step audio
Fall audio now only plays when it's intended fixing previous issues (Previously played when Jump button was pressed but Jump not trigger due to 0 Stamina)
Volume & Pitch of Falling sound is now affected the velocity of Falling player prior to hitting the ground
Updated LandingPlayer to match FootstepPlayer changes introduced by Fix FootstepSurfaceDetector raycast bug Phazorknight#248
|
hey, this is pretty cool! |
|
There was a few reasons I did it that way but in retrospect it may not be necessary. I put together a quick test using the FootstepPlayer only, and came across one major problem which is: Can't think of a way to avoid this aside from using 2 nodes for it, but if you have any ideas feel free to suggest. |
Refactored LandingPlayer to extend from FootstepSurfaceDetector class
Changed all landing variables to export variables in subgroup to audio
Changed the volume stat to use dB instead of linear volume to match the pre-existing Cogito variables Created subgroup for Footstep audio to match the Landing Audio subgroup
…eneric Refactored footstepSurfaceDetector _play_by_material function to be generic therefore allowing use of any of material_library on function call
Reworked into single AudioStreamPlayer3d node, fixed issue of sound overwrite using higher max polyphony on the node
|
Ok code has been majorly cleaned up and with the last commit, it's been combined into a single AudioStreamPlayer3D node that avoids the sound overwrite problem I was having. |
|
I would've suggested to maybe use the included QuickAudio plug in that spawns/pools Audio players as necessary. Thanks! |
|
Oh a plugin wasn't even needed, I just missed a basic Godot feature. Just needed to set the AudioStreamPlayer3D to have polyphony to fix it, so set that to 8 max now instead of 1. |
…lay_interaction function
niefia
force-pushed
the
landing-audio
branch
from
4afb1dc to
b5a9163
Compare
…allow for custom pitch/volume Previous version still had issues with the volume and pitch of the audioplayer3d being overwritten mid sfx, so the landing sound would only partially play in the correct pitch/volume before changing to incorrect pitch/volume when footsteps started. Fixed this by creating a QuickAudio play_sound_3d to play landing audio with custom parameters
|
It's ready to merge now. Functionality seems to be perfect from testing, and just put out a last commit to improve the readability of variables and comments before it gets merged. |
|
Amazing work, thanks so much for this! Merging. |
Basic attempt at a Materials based Fall landing audio player, using the same logic as the Step audio to determine materials.