-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buttons & Switches interact to all hits #261
Conversation
Buttons previously only activated with Hitscan weapon, now should activate with Projectiles Switches now react to both Hitscan & Projectiles
Hey, thanks so much for this! Looks pretty good, but I'd reckon this behavior should be easy to switch on/off (and maybe even more fine-tuneable? There's games where I wouldn't want all switches to be triggered by shooting at them. Also PREY 2017 comes to mind, where only the foam darts let you activate the display buttons... |
We may have to edit the Damage system then to tell us what caused the damage as currently it'd be impossible to do a setup where Soft Projectiles can work and Hitscan damage can't. Hitscan = true, Projectile = true - Current setup, activates on any damage I started writing a hacky workaround that passes item reference through from the weapon to the func damage of the hitbox, but that seems against the immersive sim spirit since we should probably rely on some sort of "damage type" rather than using specific references |
Yeah, I'd hold off on that until the whole I don't see this as a high-prio feature. Then any future |
Removed Health attribute, Hitbox directly calls the _on_damage_received to interact
Just removed the health attribute to simplify it. Currently switches don't react to hits but buttons do, so it may still be worth merging this one just for the sake of having consistent behaviour between them. With the idea of revisiting the issue in future once the damage system has been updated Could also remove the CogitoProperties if you'd prefer that for now, but it'd cause no reaction from projectiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally getting around to reviewing this.
Appreciate your work to getting these nodes updated and consistent.
Buttons previously only activated with Hitscan weapon, now should activate with Projectiles.
Switches now react to both Hitscan & Projectiles.
Technically also possible to hit with Pickaxe but difficult to line up due to Pickaxe collision box being tiny and not intersecting with the players crosshair. May be worth enlarging Pickaxe Collision area