Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sittable controller support #304

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Sittable controller support #304

merged 2 commits into from
Oct 10, 2024

Conversation

niefia
Copy link
Collaborator

@niefia niefia commented Oct 3, 2024

Sittable controller support, only basic version that allows free look currently.

Refactored Sittables Process into it's own function _process_on_sittable

Sittable controller support, only basic version that allows free look currently.

Refactored Sittables Process into it's own function _process_on_sittable
@Phazorknight
Copy link
Owner

Hey, thanks for this. I've had a family emergency, so for the next couple weeks, I won't be able to work on Cogito as much as I used to. I'll trust all Cogito collaborators to review and approve any PRs and merges.

Added double empty line before functions for Sittables code to match existing formatting and improve readability
Copy link
Owner

@Phazorknight Phazorknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end! Maybe not perfect but definitely improves the behavior.
Thanks for this!

@Phazorknight Phazorknight merged commit 8d466e8 into Phazorknight:main Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants