Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saves try crouch to avoid issues on save game load #307

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

OvercastInteractive
Copy link
Collaborator

Save the variable 'try_crouch' in CogitoPlayer and ensures crouching doesn't interfere with other movement actions.

  • Tested saving and loading from beneath the stairs with "Toggle Crouching" set to both off and on
  • Tested behavior with keypad interaction, while attempting to sprint and sit

Save the variable 'try_crouch' in CogitoPlayer and ensures crouching doesn't interfere with other movement actions.

- Tested saving and loading from beneath the stairs with "Toggle Crouching" set to both off and on
- Tested behavior with keypad interaction, while attempting to sprint and sit
@OvercastInteractive
Copy link
Collaborator Author

I was in the process of writing up a bug report but decided to fix the issue myself as it wasn't too problematic. I found that the player could get stuck if saving the game while crouched beneath the stairs and then loading from main menu.

In this video "Toggle Crouching" is set to OFF in options and I'm holding the crouch button down while entering the pause menu and pressing save. Then on save game load the player character automatically stands up and gets locked in place.

Crouch.breaks.on.load.mp4

@Phazorknight
Copy link
Owner

Hey, thanks for this. I've had a family emergency, so for the next couple weeks, I won't be able to work on Cogito as much as I used to. I'll trust all Cogito collaborators to review and approve any PRs and merges.

@OvercastInteractive
Copy link
Collaborator Author

No problem @Phazorknight, hope all will be well with your family. @niefia has been quite active here so perhaps they can review this minor commit before merging.

@niefia
Copy link
Collaborator

niefia commented Oct 7, 2024

@Phazorknight Sorry to hear that and hope things are things are ok.

I can definitely step in to handle some PR reviews and merges in the meantime.

@OvercastInteractive Tested it, and this one looks good to merge, so I'll do that now

Copy link
Collaborator

@niefia niefia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and fixes a couple of bugs, nice one!

@niefia niefia merged commit e21c009 into main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants