-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plug-in restructuring + COGITO Editor tab #311
Conversation
This adds the Cogito plugin tab at the top and restructures some files. Very early so bugs and errors are still expected. If you pull this, you prob want to : 1. Make sure under plug-ins that Cogito is switched off. 2. Make sure all Cogito autoloads are removed. 3. Then reactivate the plug in (this should automaticall add the correct autoloads) 4. Maybe reload the project to be sure.
Still needs a bit more cleanup.
Little heads up: As this moves pretty much all cogito files to a different directory, some references might break (though I tried to update all of them). Might work better if dowloaded and tested in a blank project. |
Have only had a quick look at this so far, will review it properly tomorrow. But just a quick issues fix |
Just a quick look from me as well. Prior to resolving the issues that @niefia pointed out, I did come across an error where input action "pause" didn't exist, which must have been a custom legacy input action used prior to using the built-in "ui_cancel". I'll continue testing it out this weekend. |
Scene references that I needed to reconnect: |
…changed to "menu")
@niefia / @OvercastInteractive |
Can't seem to find any issues with it at this stage, so technically looks good to merge now. However should probably also make sure all of the moved files match their latest versions on main to avoid losing any progress, |
Agreed, will do one more commit now that grabs the latest from main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs perfectly as expected, so looks good to merge now.
Haven't been able to manually verify every change obviously, but since it runs fine I'd say that's good enough.
If there are any problems introduced with this restructuring I haven't been able to find them.
/COGITO/
files toaddons/cogito/
Cogito
editor tab to offer some global options.