Damage rework - Hit position & Direction #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked the damage system to include Hit position & direction Added options to instantiate scenes at either global or local hit position Added option to apply force to Rigidbodies on hits Added option to spawn decal on any hitscan collision WIP - Still need to sort melee weapons position
Removed direct player references for better multiplayer support in future Fixed button damage interaction Also fixed a typo in the readme
Added option of Hitbox-Collider melee collision, seems from my testing to be more accurate since it uses the actual hitbox, but less reliable so have it as an option. Added knockback to the NPC so they can respond to damage
|
Hey, wanted to check in if this is still gonna be updated or if it's ready for review? |
|
It's mostly done, just want to rework bullet impact decals before merge. Haven't been able to work on it much lately but will try and get that done today |
Added Bullet decal pool , full credit to Majikayo Games' SimpleFPSController for that code and the decal image. Refactored laser rifle to separate collision decal from collision scene Bullet decals seem fairly buggy in the lab, but work fine in the lobby map, may be a collisions issue with lab meshes
Added collision settings Removed testing meshes from bullet decal
|
Hey, just gave this a bit of a test today. Overall it's working great! The bullet decal seems to work especially well. |
Phazorknight
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
I want to merge in some of these features so I'm gonna approve this.
@niefia thanks so much for your work on this! If you continue to tweak this, please make a new PR from main!
Phazorknight
added a commit
that referenced
this pull request
Dec 9, 2024
Fixed issues that came with mergin in PR #317 due to just being a bit behind main. Updated more scripts to use Cogito debug logging. Minor cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - Still need to sort melee weapons hit position