Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Cogito to Godot 4.3 #320

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Updating Cogito to Godot 4.3 #320

merged 3 commits into from
Oct 31, 2024

Conversation

Phazorknight
Copy link
Owner

This PR contains all changes related to making sure Cogito works in Godot 4.3.

@OvercastInteractive
Copy link
Collaborator

I didn't run into any errors in the two main scenes (Lobby, Laboratory) while testing out all of the systems using gamepad.

One issue (not relevant to the 4.3 update but from reorganizing cogito as an addon) I'm seeing is out-of-date icon file paths:
Cogito_Icon_References_Not_Found

Did find one issue in the legacy demo scene in which the key on the nearby shelf wasn't able to open the door:
Cogito_LegacyDemoScene_Key_Unusable

@Phazorknight
Copy link
Owner Author

@OvercastInteractive thanks for catching these! Both should be fixed in the latest commit.

@ac-arcana
Copy link
Collaborator

Hey just wanted to leave a note that I do see the request for me to review, just haven't had time for any dev related stuff the next few days. I will review it in the next couple of days.

@Phazorknight
Copy link
Owner Author

@ac-arcana oh no rush, I've added all contributors for a review request, but technically only one approval is needed (if it's good)

@OvercastInteractive
Copy link
Collaborator

I was hoping to do further testing before adding a review however my graphics card has been having issues with Godot 4.3 using the Forward+ renderer (for multiple projects not just Cogito!) 😥

Has anyone else had this issue with Godot 4.3 using Forward+?

Cogito_4 3_ForwardPlus_Rendering_Issue_01

@Phazorknight
Copy link
Owner Author

Has anyone else had this issue with Godot 4.3 using Forward+?

@OvercastInteractive Yikes. When did this start? Does this not happen on Godot 4.2? Definitely seems GPU related, might wanna update/reinstall your drivers to see if that helps.

@Phazorknight
Copy link
Owner Author

Giving this another bump for review! Would like to get this folded in so other PRs can be made compatible as well.

Copy link
Collaborator

@OvercastInteractive OvercastInteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good from my end.

@Phazorknight Phazorknight merged commit 85ab495 into main Oct 31, 2024
1 check passed
@Phazorknight Phazorknight deleted the godot-4-3 branch October 31, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants