Initial attempt at a basic vending machine, located in the breakroom #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a vending machine scene, which uses a cogito button and the currency check - Added cogito_vendor.gd which handles spawning, manages its own inventory and provides interaction hints - I moved some code in cogito_button.gd from interact() to press() which is both more appropriate and prevents a bug in which I would be charged for a transaction, but the press() signal would never go through because the transaction was invalid
- Limiting spawn delay to always be less than the button press cooldown time prevents any issues in which the wrong number of items is spawned (due to spamming the vending machine button)
BrodyB
suggested changes
Oct 29, 2024
There was a problem hiding this comment.
This is looking solid!
However, I do notice a soft error on picking up a health potion with this update. This is because the 2D health potion sprite auto-converts to a 3D texture at runtime because it's being used on a 3D Sprite node in the vending machine scene.
I have a fix for that on my own version of vending-machine, which I can push if I have change permissions (I removed the sprite and made a jokey soda brand with text), or you can do a similar change.
It's a very minor thing, but probably best not to introduce any errors at all.
- Duplicated the health potion texture and assigned the duplicate to the vending machine's Sprite3D to avoid auto-converting the health potion item icon to the wrong format. Thanks to @BrodyB for spotting this!
|
Hey thanks @BrodyB! I couldn't figure out how to grant you change permissions 😖 so I went ahead and made the changes. Let me know if you spot anything wrong with it. |
Phazorknight
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cogito_buttonandCurrencyCheckcogito_vendor.gdwhich handles spawning, manages its own inventory and provides interaction hintsinteract()topress()which is both more appropriate and prevents a bug in which I would be charged for a transaction without thepressed()signal ever being sent because they were handled independently. In short, the transaction only goes through oncecogito_button.gd press()is actually calledis_dispensingwhich allows the player to save the game while dispensing of the object is running a timed delay. This means when loading the game, any items that hadn't yet been dispensed (saving and quitting prior to dispensing the item) will still be dispensed.