Removing Cogito Editor Tab, instead using globals + custom resource CogitoSettings #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phazorknight
requested review from
ac-arcana,
niefia and
OvercastInteractive
Changed the way carryable position is calculated (as pointed out in issue #331 ). This adds a simple marker3D as a position node, but technically this is not required.
Code cleanup: - Replaced print functions with CogitoGlobals.debug_log Wieldable Laser Rifle: - Added muzzle flash particle effect (triggered via animation) Cogito Scene Manager / CogitoSettings: - Made sure fade duration gets loaded properly.
OvercastInteractive
approved these changes
Nov 23, 2024
|
@OvercastInteractive Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will get rid of the Cogito Editor Tab and it's options.
Instead, Cogito will use a new global/autoload script called
cogito_globals, which loads a new custom resource CogitoSettings.As a lot of script referenced
CogitoMainand now instead referenceCogitoGlobals, this PR touches a lot of files.I commented out the
EditorInterfaceline that caused the issues on exported builds. I kept the function that creates a default project input map in, in case we find a way to implement it in a better way in the future.