Fix head's position offset in stair stepping by using only y component of the result #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of the result. It seems there is a bug or limitation in Physics Engine when collision shapes change in runtime.
Phazorknight
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is a bug or limitation in Physics Engine when collision shapes change in runtime that cause result of body_test_motion to be unreliable, for example in current implementation of stair stepping we used body_test_motion to check motion only in y axis but in the result, by calling get_reminder or get_travel functions we get values that x and z are non-zero too.
This video shows what happen when bug isn't fixed and after some crouch/auto-uncrouch in window, camera goes through walls because head offset changed in x and z wrongly:
rec3.mp4