Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment testnet #413

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

deployment testnet #413

wants to merge 3 commits into from

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Jan 8, 2025

No description provided.

@gangov gangov self-assigned this Jan 8, 2025
@gangov gangov requested a review from ueco-jb January 8, 2025 15:20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the deployment failed with more than 7 zeroes initially, I think I left that in the history. I can revert that, but it shouldn't affect the math at all

@gangov gangov force-pushed the kalo/deployment_testnet branch from e97b5fc to 1cb486e Compare January 20, 2025 08:56
@ueco-jb
Copy link
Member

ueco-jb commented Jan 21, 2025

Please make those changes to deployment script here only; revert those changes in the math.
Create another PR if necessary.

@gangov gangov force-pushed the kalo/deployment_testnet branch from 1cb486e to 115559e Compare January 21, 2025 12:50
@gangov gangov force-pushed the kalo/deployment_testnet branch from 115559e to 3c42f63 Compare January 21, 2025 12:51
@gangov
Copy link
Collaborator Author

gangov commented Jan 21, 2025

reverted the commit that made changes to pool_stable/math.rs and rebased from main

@gangov gangov requested a review from ueco-jb January 21, 2025 12:58
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gangov
Copy link
Collaborator Author

gangov commented Jan 27, 2025

putting this on hold until we merge officially #409 as the script is using constructors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants