Stake: test for migrating the stake contract #432
Merged
+621
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangov
changed the title
some progress
ueco-jb
reviewed
Jan 31, 2025
contracts/stake/src/contract.rs
Outdated
Comment on lines
279
to
281
| fn unbond_deprecated(env: Env, sender: Address, stake_amount: i128, stake_timestamp: u64) { | ||
| sender.require_auth(); | ||
| env.storage() |
There was a problem hiding this comment.
This one is the new one, not the deprecated.
There was a problem hiding this comment.
that was a quick draft, I think I might be able to optimize both. Actually needed this because of how we check for pending rewards
ueco-jb
reviewed
Jan 31, 2025
Comment on lines
+525
to
+526
| fn withdraw_rewards_deprecated(env: Env, sender: Address) { | ||
| env.storage() |
There was a problem hiding this comment.
The old function were supposed to become a deprecated ones.
There was a problem hiding this comment.
what I understand is withdraw_rewards from the current main branch is supposed to become withdraw_rewards_deprecated and the function withdraw_rewards is from the stake contract tag v1.0.0. Is it vice versa?
|
merging into the feature branch of the stake replacement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.