Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

fix download of mednist #101

Merged
merged 1 commit into from
May 18, 2020
Merged

fix download of mednist #101

merged 1 commit into from
May 18, 2020

Conversation

mibaumgartner
Copy link
Member

Short Description

Please give a short summary of the main points of this PR

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@mibaumgartner mibaumgartner added the ReadyForReview Ready for review label May 18, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          36       36           
  Lines        1384     1384           
=======================================
  Hits         1354     1354           
  Misses         30       30           
Flag Coverage Δ
#unittests 97.83% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71367a...d39d0c0. Read the comment docs.

@justusschock justusschock merged commit 71cb42f into master May 18, 2020
@justusschock justusschock deleted the cls_example branch May 18, 2020 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ReadyForReview Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants